Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the percentage-number placeholder name #165

Merged
merged 1 commit into from
Jun 26, 2021
Merged

fix the percentage-number placeholder name #165

merged 1 commit into from
Jun 26, 2021

Conversation

emphasize
Copy link
Contributor

@emphasize emphasize commented Jun 21, 2021 •
edited
Loading

Fixes the wrong placeholder name resp. add percentage-number.dialog for those languages missing the dialog
mentioned in #164.

Type of PR

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

CLA

👍

chrisveilleux
chrisveilleux approved these changes Jun 26, 2021
View reviewed changes
Copy link
Member

@chrisveilleux chrisveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution... and for catching some things I missed.

@chrisveilleux chrisveilleux merged commit b7a4984 into MycroftAI:21.02 Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisveilleux chrisveilleux chrisveilleux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emphasize @chrisveilleux